From 7c3ec901cd71bd860c6ab81b41d240090be23b2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pedro=20P=C3=A9rez?= Date: Thu, 23 Oct 2025 00:18:39 +0200 Subject: [PATCH] update gitignore, makefile and readme --- .gitignore | 1 + Makefile | 27 +++++++++++++++++++++++++++ README.md | 6 ++++++ 3 files changed, 34 insertions(+) diff --git a/.gitignore b/.gitignore index 49d1813..7bee8aa 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ .sqlfluff +*.out diff --git a/Makefile b/Makefile index 4fda387..4e36e71 100644 --- a/Makefile +++ b/Makefile @@ -20,3 +20,30 @@ migrateup: # Run all services run: go run ./service_a/server/main.go & go run ./service_b/server/main.go + +.PHONY: test +# Run all tests with coverage +test: + @echo "Running tests for service_a..." + cd $(SERVICE_A) && go test ./... -coverprofile=../service_a_coverage.out + @echo "Running tests for service_b..." + cd $(SERVICE_B) && go test ./... -coverprofile=../service_b_coverage.out + @echo "\nCoverage reports generated:" + @echo " - service_a_coverage.out" + @echo " - service_b_coverage.out" + +.PHONY: coverage +# View coverage reports in browser +coverage: + @echo "Opening service_a coverage report..." + cd $(SERVICE_A) && go tool cover -html=../service_a_coverage.out + @echo "Opening service_b coverage report..." + cd $(SERVICE_B) && go tool cover -html=../service_b_coverage.out + +.PHONY: coverage-func +# Show coverage summary in terminal +coverage-func: + @echo "Service A Coverage:" + cd $(SERVICE_A) && go tool cover -func=../service_a_coverage.out + @echo "\nService B Coverage:" + cd $(SERVICE_B) && go tool cover -func=../service_b_coverage.out diff --git a/README.md b/README.md index 13f31d3..5ba1a7f 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,12 @@ Compilar todos los servicios e iniciar los contenedores Docker. `docker compose --env-file up --build` +## Decisiones técnica + +1. Hablar sobre la función normalize, repetición de parse float. Justificar que se puede haber extraído a una función, pero ambas opciones son válidas (YAGNI) + +2. Hablar sobre las sobreabstracciones que se hacen en el código. Hay que busca un punto de equlibrio entre abstraer o ser explícito. + ## Entorno desarrollo Linux Fedora 41 6.16.11-200.fc42.x86_64